1. temporarily removed my "Pyromancer" and "Terravore Turmoil" decks. Both performed very badly in my AI comparison done here: http://wololo.net/forum/viewtopic.php?f=3&t=736
While having low-performing decks is not a bad thing per se (actually we *need* some low-performers, as stepping stones for beginners), these two decks currently throw AI deficiencies into the face of the players (targeting problems / fetchlands), and we don't want to do that. Players should feel that they beat the low-perfoming decks because of their own improving skills, not because the AI can't play its own deck.
I'll re-add both decks after the next release, hoping that we can improve the AI until the release after that.
2. Added "Millage" and "Bad Dreams" decks by Niegen. I see that we are in "bug fixes only" mode since yesterday, but I had announced these additions to Niegen two days ago, and he liked the prospect, so I didn't want to cancel the additions.
3. Updated "Kobold Overlord" deck with two flyers, this is actually a week-old change that I just hadn't submitted so far because it was so minor.
I'll also do a general deck audit to prepare for the next release (respective task will be added to Googlecode tracker). Since we're in "bug fixes only" mode, I'll just fix some obvious mistakes - it's always tempting to do last-minute tweaks and improvements, but I wouldn't want a card or deck that was added late, and hardly tested, to cause problems after the release.
This means we can release the next version with 50 AI decks, more than double than the previous version (which had 24). :)
* We only want to record misses when the file doesn't exist. Item can be null if we're out of memory for whatever reason, resulting in an invalid miss.
* mError status was being reset properly. What I'm thinking happened is that somewhere along the line, a file would miss and return CACHE_ERROR_404. Then, cache.find() would fail because the file was not in the cache, but because mError wasn't reset it would still report CACHE_ERROR_404. In some cases, this would be overwritten (causing the flickering single frame wrong image), and in others this would erroneously report a miss.
* Tested through three demo games and three player games. Shop screen still shows, didn't notice any missing sounds.
* Confirmable options used to only check for confirmation when selecting another option. They now autoconfirm when saving & exiting. This bug could possibly result in loading the wrong theme. Fixed.
* Changing profiles, canceling, then changing to the profile again could also result in improper theme loading. Fixed.
* The alternate theme is just useful for testing themes, but please comment on the changes to the main theme.
* Options reading and initializing separated from UI.
* Options UI abstracted a bit, made more easily extensible.
* With some extension, the options UI could be used as the basis for more complicated themes, if we load a file and use it to do stuff like GameStateOptions::Start()
- fix for issue 108 (mana icon disappears)
- potential fix for issue 110 (victory bonus texts). Need to check
- Fix for issue 100. A better solution would be to "stretch" the cards in hand the way it is done for the rest of the game, but this will do for now as it is a border case
- Fix for issue 55. We'll remove 2 players mode for now, and put it back when/if we get network play
* Some cleaning after r1062 code review.
- Remove code that was never reached.
- Remove a useless function.
- Make GuiPlay treat cards that are both spells and creatures as
creatures and not spells.
