- removed useless "color=" lines
- Added color override for cards such as crimson kobolds (note: color should be after the "mana" line to avoid side effects)
Also you can see in the todo.dat I tried Sift, Stampeding Wildbeast and Denizen of the Deep, all not working...
Also the following cards can probably be parsed: 1205: //Lifetap; 1625: //Lifeblood; 2593: //Thoughtleech and removed from both MTGAbility.cpp and Allabilities.h (for AGiveLifeforTapped***)
Grü
L.
NOTE that all these additions to the foreach parser are only available for the "inplay" area... "countcards" will need to be updated in order to have thing such as graveyard or hand to be taken into consideration (but when it will be done cards such as Spontaneous Generation - MRQ, could be added)
Also updated (tentatively) the "cantbeblockedby" in the parser it still does not work...ARG... but I can feel that I'm not far away from the solution...
We need also to go through some of the cards.dat to be sure we are not missing any possible addition ...
I tryed everything for weeks, adding lines of codes with no success...Finally the answer was so simple as 2 lines of code...
Also added/removed from code Spitting earth and corrupt... Need to chase and remove all the lookalike/alias in the rest of the code. And also as usual will require further testing...
Grü.
L.
Test suite passed with exception of Hymn of rebirth ?? also at least dingus egg is also OK.
Ideally the whenever thing should be coupled with a kind of targetchooser thing to be put in the parser (would also allow colored cards...) ..
Todo: add a may ability option since lot of cards with this function use "may" (e.g. Deathgreeter - ALA and Leonin Elder - MRD)
I did not remove the now obsolete code dingus egg and ankh of mishra...will wait until new portion of code is tested more..
Grü
Few comments:
I spent quite some time to make it work... made some test all working but experienced some random crash in windows version (debugging did not help much) don't know if i broke something or if it is due to other SVN addition.
Some other cards are similar and could be hardcoded/aliased (Overtake - MRQ, Ray of Command - ICE,MIR, Slave of Bolas - ARB, Spinal Embrace INV, Unwilling Recruit EVE) we could discuss about them...
I think it is the last card that was missing for the red premade 10E deck. Now 10E has 255 cards and is the set with the most cards...
Grü.
L.
Added Graveborn Muse (just missing one muse now, too complicated for me).
Added Beacon of destruction,unrest and immortality.
Added Traumatize
Added Verdant Force
All tested (except beacon of unrest) and working.
Added "untap all" to the parser (not tested but should work since it is the same as tap all)
Modified "cantbeblockedby" also still don't function properly, atm it cause the creature to be "unblockable"... Should work, I don't get it !!! (Why ???)
Also added Seedborn Muse (like all the Muse a very Powerfull card), especially as combo with cards that "DOESNOTUNTAP" during your untap phase...
I tested Elven Riders successfully, but not juggernaut yet... Also if this new keyword function correctly we remove abilities like FEAR and UNBLOCKABLE... Needs to be further tested...
Feedback and extensive test are welcome on this one...
Added ability DOESNOTUNTAP , see _cards.dat from 10E (Colossus of sardia, dehydratation). Test suite OK. The ability does not work with enchant creature (as for protection from...) So Dehydratation is hardcoded (can be aliased if necessary) Small bug with dehydratation, will untap creature when cast... WHY ? Any Idea/Solution welcome...
POR - Removed Man'O'War + Added Hulking Cyclops, Hulking Goblin, Nature's Cloak, Gravedigger, Fire tempest, Dry Spell,Craven Knight, Craven Giant (sorry for this addition could not refrain after seeing them, were probably forgotten)
TMP - removed Cloudchaser eagle
LEG - Corrected Concordant Crossroad
USG - Removed Dark Hatchling, Monk realist
RAV - REmoved Keening Banshee, also tentative to fix Tolsimir Wolfblood (legendary is not working)
EVE - REmoved Noggle Bridgebreaker
Also made an update and added silly name for AI deck + note that deck 22 is using cards from morningtide and deck 23 cards that the AI do not use correctly (activated abilities) but is not the only one, AI decks needs update/amelioration.
