-Load shop and backdrop in 5551. @Jeck feel free to implement the "default as 5551" for jpegs as well if you think it's worth it. I think this change is the safest for the time being, but that's mostly because I'm too lazy to touch JGE
* Restored quad locking to textures, but ignore quad locks when Release(JTexture*) is explicitly called. (I just copied and modified the code from the template, rather than do anything elegant).
* Some minor fiddling with cache error states.
* Removed all calls to Release(JQuad*).
* Updated flatten(). Prior flatten was buggy beyond belief.
* Done some extensive testing, but if this causes more trouble than it fixes, we'll have to revert. It's too close to release time.
Without this quick and dirty fix if you have 2 thieving magpie in play you get twice the bonus if only 1 deals damage (also you draw 2 cards instead of 1).
Disconcertingly enough, this seems to resolve issue 109. Ran demo mode for 1 hour (w00t no crashes!), played five manual games, shop appeared fine... but why would an mObject ever be null? I'm not so sure about this commit. It "fixes" the issue, but doesn't do anything for the underlying cause. For all I know, I might just not have re-encountered issue 109 yet... still, it's not a /bad/ commit. In the worst case, it does some unnecessary sanity checking. There's potential for a a hang if item is NULL in Update(), if input doesn't get passed along in a way that allows the player to exit... But I think that's what the call to JGuiController::Update is for.
Thoughts?
Note: I used Google to match our deck descriptions with existing card flavor texts, and then used Google again to check whether the text was in the public domain (the fact that a verse from the Rime of the Ancient Mariner appears on the Scathe Zombies card, does obviously not preclude us from using Coleridge's work ourselves). I may have missed something in wither process, please report if I did.
For the time being, this is unfortunately a loss in quality, since the official flavor texts were obviously better than the replacement texts I thought up in a few minutes. Feel free to replace my texts with something better. This could be original work of yours, or something that's clearly in the public domain. The latter includes classical literature and poetry btw. We already have Milton, Browning, and Coleridge in the flavor texts, and we could certainly use more of that. Unfortunately I've read about 100 SciFi/Fantasy books for every book of classical poetry I even touched, so I'm in a bad position to provide such material, but perhaps someone else can.
I discussed this change with wololo beforehand, because it required changes to decks that weren't made by me.
Please review / criticize.
* In GuiBackground, we now load and use all of backdrop.jpg. This is for effects like that in Jade. It's an extremely minor change, so shouldn't effect stability.
-fix issue mentioned at http://wololo.net/forum/viewtopic.php?f=4&t=371&p=6296#p6296 . I touched a very sensitive area of the code so please let me know if something goes wrong with this revision with spells or abilities that involve targets and/or sacrifice
* I've tried to keep the same kind of luminosity as the old backdrop.jpg, and matched the psuedo-jade to the colors of the phase icons. I'm still not certain what to do with wood/gold/goldglow, as they clash terribly.
* The whole "recessed playarea" thing was inspired by the recent forum posts of Kaioshin.
Thoughts, comments, suggestions, etc?
- Updated credits, please let me know if I misspelled your name, or if I forgot someone you think is important (don't feel offended if I did, I have bad memory)