Mahtan/wagic
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix for flip cards changing name after a transforms ability...

Browse Source 
I remember adding that patchwork fix a long time ago, not sure if whatever it fixed was even really an issue or just a overprotective line i added. either way if it was an issue, addType is what should re-add the name, not transformer ability.
This commit is contained in:
omegablast2002@yahoo.com
2012-05-01 15:52:16 +00:00
parent 50059e0b89
commit b0ab33be82
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/mtg/src/AllAbilities.cpp
+8 -3
View File
@@ -1641,6 +1641,7 @@ int AAFlip::resolve()
if(!fcard) return 0; if(!fcard) return 0;
MTGCardInstance * myFlip = NEW MTGCardInstance(fcard, _target->controller()->game); MTGCardInstance * myFlip = NEW MTGCardInstance(fcard, _target->controller()->game);
_target->name = myFlip->name; _target->name = myFlip->name;
_target->setName(myFlip->name);
_target->colors = myFlip->colors; _target->colors = myFlip->colors;
_target->types = myFlip->types; _target->types = myFlip->types;
_target->text = myFlip->text; _target->text = myFlip->text;
@@ -3849,9 +3850,13 @@ int ATransformer::destroy()
_target->addType(*it); _target->addType(*it);
} }
} }
//in the case that we removed or added types to a card, so that it retains its original name when the effect is removed. ////in the case that we removed or added types to a card, so that it retains its original name when the effect is removed.
if(_target->model->data->name.size())//tokens don't have a model name. //if(_target->model->data->name.size())//tokens don't have a model name.
_target->setName(_target->model->data->name.c_str()); // _target->setName(_target->model->data->name.c_str());
//edit: this ability shouldn't have to reset the name on a card becuase removing a subtype changes the name of a land.
//that should be handled in addType...not here.
//im sure commenting this out will reintroduce a bug somewhere but it needs to be handled correctly. furthermore, why does adding and removing a type touch the name of a card?
} }
return 1; return 1;
} }