From 682af98bf799e4660fe6eef38f78b217693d2689 Mon Sep 17 00:00:00 2001 From: "omegablast2002@yahoo.com" Date: Wed, 8 Dec 2010 14:37:39 +0000 Subject: [PATCH] moot pointed out i made a boo boo in STANDARDABILITYGRANT thanks you! forgot to add the "suggest good" part of the condiation...as we dont act to give a creature the ability 2 times. (atleast until stacking abilities are added) --- projects/mtg/src/AIPlayer.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/projects/mtg/src/AIPlayer.cpp b/projects/mtg/src/AIPlayer.cpp index 6a94da9d4..facf7bbe5 100644 --- a/projects/mtg/src/AIPlayer.cpp +++ b/projects/mtg/src/AIPlayer.cpp @@ -446,10 +446,6 @@ int AIAction::getEfficiency() { efficiencyModifier /= p->game->hand->nb_cards; } - - // Z, please review. If this condition is hit, it's immediately wiped out later at line 464 (the don't give flying twice check), - // since both satisfy the check for (target->has(a->abilitygranted)). - // Is this if statement section obsolete? if (suggestion == BAKA_EFFECT_BAD && p != target->controller() && target->has(a->abilitygranted) && p->isAI()) { efficiency += efficiencyModifier; @@ -460,7 +456,7 @@ int AIAction::getEfficiency() efficiency += efficiencyModifier; } - if (target->has(a->abilitygranted)) + if (suggestion == BAKA_EFFECT_GOOD && target->has(a->abilitygranted)) { //trying to avoid Ai giving ie:flying creatures ie:flying twice. efficiency = 0;