Implemented a lazy load pattern for the deck stats - when the DeckMenu is displaying decks, it calls LoadStats() for only the ones visible in the list. This helps reduces the lag that occurs each time we attempt to load all the AI decks during match selection.

This still could be improved - DeckMetaData's constructor loads an MTGDeck object to parse out the name of a deck from its file.  This means that we crack open 106 files on the first attempt to show the list of opponent decks. I started optimizing this, but reverted, as the list itself is sorted alphabetically.  Currently, with these mods, it's still taking 4 1/2 seconds on my psp to load the opponent list on the first go around.

While at it, did some cleanup - removed the need for passing around a player pointer in some of the DeckStat functions, etc.

projects/mtg/include/DeckMetaData.h

@@ -17,22 +17,21 @@ enum DECK_DIFFICULTY
 class DeckMetaData
 {
 private:
-    string _filename;
-
-    string _desc;
-    string _name;
-    int _deckid;
-    string _avatarFilename;
+    string mFilename;
+    string mDescription;
+    string mName;
+    int mDeckId;
+    string mAvatarFilename;
 
     // statistical information
+    int mGamesPlayed, mVictories, mPercentVictories, mDifficulty;
 
-    int _nbGamesPlayed, _victories, _percentVictories, _difficulty;
+    DeckMetaData();
 
 public:
-    DeckMetaData();
-    DeckMetaData(string filename, Player * statsPlayer);
-    void load(string filename);
-    void loadStatsForPlayer(Player * statsPlayer, string deckStatsFileName = "");
+    DeckMetaData(const string& filename);
+    void LoadDeck();
+    void LoadStats();
 
     // Accessors
     string getFilename();
@@ -49,6 +48,13 @@ public:
     int getDifficulty();
     string getDifficultyString();
 
+    void Invalidate();
+
+    string mStatsFilename;
+    string mPlayerDeck;
+    bool mDeckLoaded;
+    bool mStatsLoaded;
+    bool mIsAI;
 };
 
 class DeckMetaDataList
@@ -58,10 +64,9 @@ private:
 
 public:
     void invalidate(string filename);
-    DeckMetaData * get(string filename, Player * statsPlayer = NULL);
+    DeckMetaData * get(string filename);
     ~DeckMetaDataList();
     static DeckMetaDataList * decksMetaData;
-
 };
 
 #endif