Additional fix to go along with r2834 - the previous fix revealed an ugly interdependency between CardView and MTGCardInstance. Neither object owns the other, but they each have a pointer reference to each other, which is a recipe for disaster if not managed correctly. I had fixed half of the problem, where the status of a CardView being destroyed wasn't reflected in the MTGCardInstance; meanwhile, it introduced another problem where if the MTGCardInstance was destroyed first, the CardView would crash when trying to do the cleanup.

This is a classic example of why naked pointers suck!  The right way to fix an interdependency would be to have these objects hold onto weak references to each other. But that's way too big a change at this point in time, so I've added this ugly hack instead.

This will fix an intermittent crash when either accessing the library or exiting a match.

projects/mtg/src/GuiLayers.cpp

@@ -61,7 +61,18 @@ void GuiLayer::resetObjects()
 {
     for (int i = 0; i < mCount; i++)
         if (mObjects[i])
+        {
+            // big, ugly hack around CardView / MTGCardInstance ownership problem - these two classes have an interdependency with naked pointers,
+            // but the order of destruction can leave a dangling pointer reference inside of a CardView, which attempts to clean up its own pointer
+            // reference in an MTGCardInstance when it's destroyed.  Ideally, CardView should only hold onto a weak reference, but that's a bigger overhaul.
+            // For now, if we get here, clear out the MTGCardInstance pointer of a CardView before calling delete.
+            CardView* cardView = dynamic_cast<CardView*>(mObjects[i]);
+            if (cardView)
+            {
+                cardView->card = NULL;
+            }
             delete mObjects[i];
+        }
     mObjects.clear();
     mCount = 0;
     mCurr = 0;