- Created a GamePhase type to ease debug.

- Modified the testsuite and gameobserver to be able to replay all the testcases based on the actions logged during the first pass. This allows to test the action logging and replay used during undo. It's only activated in multithreaded mode and it does not work on Momir tests.
-  Modified choice logging and replay to use menuId instead of ability index, as, for some obscur reasons related to Lord, those ability indexes may change.
- Fixed bug in nextphase logging wrongly generating click actions
- Added a "stack" zone to the click ability logging to be able to replay properly interrupt
- Fixed a wonderful bug mixing card names with zone names in the actions execution engine
- Added a "combatok" action logging/execution
- Added a "clone" virtual method to MTGCardInstance and Token to be able to clone correctly the right object type. Used that in MTGGameZones::removeCard

projects/mtg/src/GameOptions.cpp

@@ -141,46 +141,46 @@ int Options::optionInterrupt(int gamePhase)
     //Huge, nearly illegible switch block spread out to improve readability.
     switch (gamePhase)
     {
-    case Constants::MTG_PHASE_BEFORE_BEGIN:
+    case MTG_PHASE_BEFORE_BEGIN:
         return INTERRUPT_BEFOREBEGIN;
 
-    case Constants::MTG_PHASE_UNTAP:
+    case MTG_PHASE_UNTAP:
         return INTERRUPT_UNTAP;
 
-    case Constants::MTG_PHASE_UPKEEP:
+    case MTG_PHASE_UPKEEP:
         return INTERRUPT_UPKEEP;
 
-    case Constants::MTG_PHASE_DRAW:
+    case MTG_PHASE_DRAW:
         return INTERRUPT_DRAW;
 
-    case Constants::MTG_PHASE_FIRSTMAIN:
+    case MTG_PHASE_FIRSTMAIN:
         return INTERRUPT_FIRSTMAIN;
 
-    case Constants::MTG_PHASE_COMBATBEGIN:
+    case MTG_PHASE_COMBATBEGIN:
         return INTERRUPT_BEGINCOMBAT;
 
-    case Constants::MTG_PHASE_COMBATATTACKERS:
+    case MTG_PHASE_COMBATATTACKERS:
         return INTERRUPT_ATTACKERS;
 
-    case Constants::MTG_PHASE_COMBATBLOCKERS:
+    case MTG_PHASE_COMBATBLOCKERS:
         return INTERRUPT_BLOCKERS;
 
-    case Constants::MTG_PHASE_COMBATDAMAGE:
+    case MTG_PHASE_COMBATDAMAGE:
         return INTERRUPT_DAMAGE;
 
-    case Constants::MTG_PHASE_COMBATEND:
+    case MTG_PHASE_COMBATEND:
         return INTERRUPT_ENDCOMBAT;
 
-    case Constants::MTG_PHASE_SECONDMAIN:
+    case MTG_PHASE_SECONDMAIN:
         return INTERRUPT_SECONDMAIN;
 
-    case Constants::MTG_PHASE_ENDOFTURN:
+    case MTG_PHASE_ENDOFTURN:
         return INTERRUPT_ENDTURN;
 
-    case Constants::MTG_PHASE_CLEANUP:
+    case MTG_PHASE_CLEANUP:
         return INTERRUPT_CLEANUP;
 
-    case Constants::MTG_PHASE_AFTER_EOT:
+    case MTG_PHASE_AFTER_EOT:
         return INTERRUPT_AFTEREND;
     }