Mahtan/wagic
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed a Bug in MusicExist method of GameStateDuel class when filename parameter was empty (this could lead to a wrong check on which soundtrack has to be played).

Browse Source
This commit is contained in:
Vittorio Alfieri
2021-10-23 21:44:28 +02:00
parent 63c5ff2789
commit 0824ea3984
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@@ -3,7 +3,9 @@
## [master] (https://github.com/WagicProject/wagic/tree/master) ## [master] (https://github.com/WagicProject/wagic/tree/master)
### 23/10/21 ### 23/10/21
- *Committed:* Renamed some decks for AI. ([Vitty85](https://github.com/Vitty85)) - *Committed:* Fixed a Bug in MusicExist method of GameStateDuel class when filename parameter was empty (this could lead to a wrong check on which soundtrack has to be played). ([Vitty85](https://github.com/Vitty85))
- *Committed:* Renamed some decks for AI. https://github.com/WagicProject/wagic/commit/63c5ff2789776a4faa70245b0f97f9b3828501b0 ([Vitty85](https://github.com/Vitty85))
### 21/10/21 ### 21/10/21
- *Committed:* Renamed a deck for AI, fixed test suite (one test seems to randomly fail on AI choice without a real bug). https://github.com/WagicProject/wagic/commit/31530215a527d37e219fbe2c9d47dab5cc584e59 ([Vitty85](https://github.com/Vitty85)) - *Committed:* Renamed a deck for AI, fixed test suite (one test seems to randomly fail on AI choice without a real bug). https://github.com/WagicProject/wagic/commit/31530215a527d37e219fbe2c9d47dab5cc584e59 ([Vitty85](https://github.com/Vitty85))

2
projects/mtg/src/GameStateDuel.cpp
View File

@@ -375,6 +375,8 @@ void GameStateDuel::End()
//TODO Move This to utils or ResourceManager. Don't we have more generic functions that can do that? //TODO Move This to utils or ResourceManager. Don't we have more generic functions that can do that?
bool GameStateDuel::MusicExist(string FileName) bool GameStateDuel::MusicExist(string FileName)
{ {
if (FileName.length() < 1) return false; // Fixed a problem when Music filename is empty.
string musicFilename = WResourceManager::Instance()->musicFile(FileName); string musicFilename = WResourceManager::Instance()->musicFile(FileName);
if (musicFilename.length() < 1) return false; if (musicFilename.length() < 1) return false;