Markus Armbruster bd6fee9f12 log: Fix qemu_set_dfilter_ranges() error reporting ...

g_error() is not an acceptable way to report errors to the user:

    $ qemu-system-x86_64 -dfilter 1000+0

    ** (process:17187): ERROR **: Failed to parse range in: 1000+0
    Trace/breakpoint trap (core dumped)

g_assert() isn't, either:

    $ qemu-system-x86_64 -dfilter 1000x+64
    **
    ERROR:/work/armbru/qemu/util/log.c:180:qemu_set_dfilter_ranges: assertion failed: (e == range_op)
    Aborted (core dumped)

Convert qemu_set_dfilter_ranges() to Error.  Rework its deeply nested
control flow.  Touch up the error messages.  Call it with
&error_fatal.

This also permits testing without a subprocess, so do that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1466011636-6112-3-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>

2016-06-20 16:38:31 +02:00

..

acl.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

base64.c

include/qemu/osdep.h: Don't include qapi/error.h

2016-03-22 22:20:15 +01:00

bitmap.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

bitops.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

buffer.c

qemu-common: stop including qemu/host-utils.h from qemu-common.h

2016-05-19 16:42:28 +02:00

compatfd.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

coroutine-gthread.c

all: Remove unnecessary glib.h includes

2016-06-07 18:19:24 +03:00

coroutine-sigaltstack.c

Remove unneeded include statements for setjmp.h

2016-03-22 19:11:15 +01:00

coroutine-ucontext.c

Remove unneeded include statements for setjmp.h

2016-03-22 19:11:15 +01:00

coroutine-win32.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

crc32c.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

cutils.c

avx2 configure: Use primitives in test

2016-06-16 18:39:04 +02:00

envlist.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

error.c

migration: add reporting of errors for outgoing migration

2016-05-26 11:31:30 +05:30

event_notifier-posix.c

event-notifier: Add "is_external" parameter

2016-04-22 16:43:56 +02:00

event_notifier-win32.c

event-notifier: Add "is_external" parameter

2016-04-22 16:43:56 +02:00

fifo8.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

getauxval.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

hbitmap.c

hbitmap: add 'pos < size' asserts

2016-06-16 15:20:37 +02:00

hexdump.c

util: Improved qemu_hexmap() to include an ascii dump of the buffer

2016-04-06 09:52:07 +08:00

host-utils.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

id.c

util: move declarations out of qemu-common.h

2016-03-22 22:20:17 +01:00

iov.c

util: move declarations out of qemu-common.h

2016-03-22 22:20:17 +01:00

log.c

log: Fix qemu_set_dfilter_ranges() error reporting

2016-06-20 16:38:31 +02:00

Makefile.objs

qht: QEMU's fast, resizable and scalable Hash Table

2016-06-11 23:10:20 +00:00

memfd.c

os-posix: include sys/mman.h

2016-06-16 18:39:03 +02:00

mmap-alloc.c

os-posix: include sys/mman.h

2016-06-16 18:39:03 +02:00

module.c

coccinelle: Remove unnecessary variables for function return value

2016-06-20 16:38:13 +02:00

notify.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

osdep.c

os-posix: include sys/mman.h

2016-06-16 18:39:03 +02:00

oslib-posix.c

os-posix: include sys/mman.h

2016-06-16 18:39:03 +02:00

oslib-win32.c

all: Remove unnecessary glib.h includes

2016-06-07 18:19:24 +03:00

path.c

util: move declarations out of qemu-common.h

2016-03-22 22:20:17 +01:00

qdist.c

clean-includes: run it once more

2016-06-16 18:39:03 +02:00

qemu-config.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

qemu-coroutine-io.c

osdep: remove use of socket_error() from all code

2016-03-10 17:19:34 +00:00

qemu-coroutine-lock.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

qemu-coroutine-sleep.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

qemu-coroutine.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

qemu-error.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

qemu-openpty.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

qemu-option.c

QemuOpts: Fix qemu_opts_foreach() dangling location regression

2016-04-28 08:18:56 +02:00

qemu-progress.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

qemu-sockets.c

util: fix comment typos

2016-05-18 15:04:27 +03:00

qemu-thread-posix.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

qemu-thread-win32.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

qemu-timer-common.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

qht.c

clean-includes: run it once more

2016-06-16 18:39:03 +02:00

rcu.c

util: Clean up includes

2016-02-04 17:01:04 +00:00

readline.c

util: move declarations out of qemu-common.h

2016-03-22 22:20:17 +01:00

rfifolock.c

rfifolock: no need to get thread identifier when nesting

2016-05-16 15:29:44 -07:00

throttle.c

throttle: refuse iops-size without iops-total/read/write

2016-06-07 14:40:51 +01:00

timed-average.c

Fix some typos found by codespell

2016-05-18 15:04:27 +03:00

unicode.c

util: move declarations out of qemu-common.h

2016-03-22 22:20:17 +01:00

uri.c

all: Remove unnecessary glib.h includes

2016-06-07 18:19:24 +03:00