zhanghailiang
b19456dd0e
char: Fix removing wrong GSource that be found by fd_in_tag
We use fd_in_tag to find a GSource, fd_in_tag is return value of
g_source_attach(GSource *source, GMainContext *context), the return
value is unique only in the same context, so we may get the same
values with different 'context' parameters.
It is no problem to find the right fd_in_tag by using
g_main_context_find_source_by_id(GMainContext *context, guint source_id)
while there is only one default main context.
But colo-compare tries to create/use its own context, and if we pass wrong
'context' parameter with right fd_in_tag, we will find a wrong GSource to handle.
We tried to fix the related codes in commit b43decb015,
but it didn't fix the bug completely, because we still have some codes didn't pass
*right* context parameter for remove_fd_in_watch().
Let's fix it by record the GSource directly instead of fd_in_tag.
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1492564532-91680-1-git-send-email-zhang.zhanghailiang@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2017-05-03 12:29:40 +02:00
..
2017-04-24 15:09:33 -04:00
2017-04-24 09:13:22 +02:00
2017-02-07 18:29:59 +00:00
2017-04-26 10:22:31 +01:00
2017-02-22 11:28:28 +11:00
2017-05-03 12:29:40 +02:00
2017-02-21 11:14:07 +00:00
2017-04-21 12:25:41 +02:00
2017-03-05 09:02:10 +01:00
2017-04-25 19:17:25 +08:00
2017-03-07 16:07:47 +01:00
2017-04-24 15:37:30 +01:00
2017-04-10 10:23:38 +01:00
2017-02-28 16:18:49 +00:00
2017-05-03 12:29:40 +02:00
2017-03-16 08:58:15 +01:00
2017-01-24 13:10:35 -08:00
2017-04-26 23:57:45 -05:00
2017-02-28 09:03:39 +03:00
2017-02-28 20:47:50 +01:00
2016-10-12 09:54:52 +02:00